Migrate AttachmentViewHolderFactory to compose #2900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LZRS
force-pushed
the
sdc-compose-attachment
branch
3 times, most recently
from
4b9b344 to
2d30047
Compare
LZRS
force-pushed
the
sdc-compose-attachment
branch
from
2d30047 to
cb041be
Compare
LZRS
force-pushed
the
sdc-compose-attachment
branch
from
cb041be to
49fdf6c
Compare
FikriMilano
suggested changes
Nov 25, 2025
| displaySnackbar(view, R.string.upload_failed) | ||
| file.delete() | ||
| return@setFragmentResultListener | ||
| val displayTakePhoto = |
Contributor
There was a problem hiding this comment.
Suggested change
| val displayTakePhoto = | |
| val displayTakePhotoButton = |
Comment on lines
+168
to
186
| coroutineScope.launch { | ||
| val attachmentMimeTypeWithSubType = context.getMimeTypeFromUri(uri) | ||
| val attachmentByteArray = context.readBytesFromUri(uri) | ||
| currentAttachment = | ||
| Attachment().apply { | ||
| contentType = attachmentMimeTypeWithSubType | ||
| data = attachmentByteArray | ||
| title = fileName | ||
| creation = Date() | ||
| } | ||
|
|
||
| val answer = | ||
| QuestionnaireResponse.QuestionnaireResponseItemAnswerComponent().apply { | ||
| value = currentAttachment | ||
| } | ||
| questionnaireViewItem.setAnswer(answer) | ||
|
|
||
| displayUploadedText = true | ||
| } |
Contributor
There was a problem hiding this comment.
maybe we can have this as a separate function?
looks very similar to line 200
Comment on lines
+200
to
+218
| coroutineScope.launch { | ||
| val attachmentMimeTypeWithSubType = context.getMimeTypeFromUri(it) | ||
| val attachmentByteArray = context.readBytesFromUri(it) | ||
| currentAttachment = | ||
| Attachment().apply { | ||
| contentType = attachmentMimeTypeWithSubType | ||
| data = attachmentByteArray | ||
| title = getFileName(context.contentResolver, it) | ||
| creation = Date() | ||
| } | ||
|
|
||
| val answer = | ||
| QuestionnaireResponse.QuestionnaireResponseItemAnswerComponent().apply { | ||
| value = currentAttachment | ||
| } | ||
| questionnaireViewItem.setAnswer(answer) | ||
|
|
||
| displayUploadedText = true | ||
| } |
github-project-automation
bot
moved this from New
to PR under Review
in Android FHIR SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2863
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.